-
Notifications
You must be signed in to change notification settings - Fork 678
Apply markdown engine to result provider #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request introduces 3 alerts when merging 4bb9018 into bcafa92 - view on LGTM.com
new alerts:
- 2 for Useless assignment to local variable
- 1 for Unused variable, import, function or class
Comment posted by LGTM.com
Currently, the parsing does not cover this case:
image
However, the [Warn] line will be parsed as one part of √ Your runtime..., so maybe its visual effect will not be so ugly.
If there is issue about it in the future, further logic can be added at that time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What will happen if we don't append √?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The RegEx captures anything in between two √. If we don't append it, the last section (normally stdout) won't be captured.
Worth to note that, with this trick, messages like [WARN] Failed to get memory percentile will be captured as one part of Your runtime beats 81.3 % of python submissions, and will also be printed out even it does not starts with √.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... still feeling the logic here is too tricky for maintaince.
It's ok to merge for now.
Uh oh!
There was an error while loading. Please reload this page.
Introduction
Solving #216 (comment)
Demonstration
image
image
image
image