-
Notifications
You must be signed in to change notification settings - Fork 689
Top voted solution webview #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sync with upstream
* fix tab-size to 4 * remove the redundant escape slash in solutionString
jdneo
commented
Mar 11, 2019
@Vigilans Sorry for the conflict made by merging another PR, would you mind to resolve it?
Vigilans
commented
Mar 11, 2019
@jdneo Conflict has been resolved.
jdneo
commented
Mar 11, 2019
Cool, I'll take a look tonight
@jdneo
jdneo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool feature! Just some comments for small changes.
@jdneo
jdneo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, still cannot get style work on my Mac...
jdneo
commented
Mar 13, 2019
@Vigilans Thank you for keep working on this PR, it's very near to get merged.
* Revert plugin modification * Move markdown style error prompt from dialog to channel
@jdneo
jdneo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work. This feature will significantly increase the user experience. And we can adopt the same render logic into the result provider and preview provider.
Introduction
Solves #96
This PR is independent with #188.
Details
Demonstration
image
image
References