Search code, repositories, users, issues, pull requests...

Copy link

Contributor

@xuzaixian xuzaixian commented Mar 5, 2019 •

edited by jdneo

Loading

Resolve #131


 Add Click the tree explorer should open the topic ( LeetCode-OpenSourc...

dbeddab

...e#132)

@jdneo

Copy link

Member

jdneo commented Mar 5, 2019

@xuzaixian Thank you for contribution.

From my understanding, after applying this change, when the user clicks on the tree node, we will generate new / open existing problem file, right?

Copy link

Contributor Author

xuzaixian commented Mar 5, 2019

yes ~

@jdneo

Copy link

Member

jdneo commented Mar 5, 2019

Emm, I'm ok to open the existing problem file.

While for the non-existing file, it will be better if we can first show the problem description to the user, and generate the file if the user has some further confirmation action. What do you think?

Copy link

Contributor Author

xuzaixian commented Mar 6, 2019

Hum....maybe we can preview the problem within a webview , and generate the file after confirmation action ?

@jdneo

Copy link

Member

jdneo commented Mar 6, 2019

@xuzaixian Exactly what I'm thinking about. And this action can be bound with a new command called Preview Problem.

Would you like to have a try to implement this feature first?

Copy link

Contributor Author

xuzaixian commented Mar 6, 2019

ok, i will work on it.

@jdneo

Copy link

Member

jdneo commented Mar 6, 2019

@xuzaixian I'm thinking that if we should create a new command or just reuse Show Problem

Copy link

Contributor Author

xuzaixian commented Mar 6, 2019

I prefer to create a new command Preview Problem .

use 'Show Problem' when they want to code right now
use 'Preview Problem' when they want to read description.
we can provide more choices to user 🤣

@jdneo

Copy link

Member

jdneo commented Mar 6, 2019

@xuzaixian So what should we do when user left-click on the node?

Copy link

Contributor Author

xuzaixian commented Mar 6, 2019

@jdneo How about just preview the problem description when user left-click?
We can provide an extra button called Code Now or something else .. in preview window,
The user can click button to code right away.
Also provide a new menu option in right-click menu called Code Now.

This sounds convenient.

@jdneo

Copy link

Member

jdneo commented Mar 6, 2019

@xuzaixian Yes, sounds good

@jdneo

Copy link

Member

jdneo commented Mar 6, 2019

Hi @xuzaixian,

I noticed that a lot of diffs is caused by reformating the package.json. Would you mind to revert those formatting changes? This could make it easier to review.

Thanks!

@jdneo jdneo self-requested a review

March 6, 2019 10:48


 Add Preview Function( LeetCode-OpenSource#132 )

be596bd

@xuzaixian xuzaixian force-pushed the master branch from e1ebd7c to be596bd Compare

March 6, 2019 11:54

Copy link

Contributor Author

xuzaixian commented Mar 6, 2019

sorry for that 😢

jdneo

jdneo reviewed

Mar 7, 2019

package.json Outdated Show resolved Hide resolved

src/commands/show.ts Outdated Show resolved Hide resolved

src/explorer/LeetCodeNode.ts Show resolved Hide resolved

src/shared.ts Outdated Show resolved Hide resolved

src/utils/webviewUtils.ts Outdated Show resolved Hide resolved

jdneo

jdneo reviewed

src/explorer/LeetCodeNode.ts Outdated Show resolved Hide resolved

xuzaixian added 3 commits

March 8, 2019 15:02


 Add Preview Function( LeetCode-OpenSource#132 )

7f8d3bd

Remove unused function
Use rem instead of px
Use the VS Code embed CSS vars in Preivew Webview
Use spaces instead of tabs in package.json
Use previewProvider to manage preivew logic


 Fix: TsLint

80ef091

https://marketplace.visualstudio.com/items?itemName=ms-vscode.vscode-typescript-tslint-plugin


 Remove Blank Line

e9502d0

@jdneo

Copy link

Member

jdneo commented Mar 8, 2019 •

edited

Loading

@xuzaixian You can install an extension called: TS Lint, to help you resolve those lint errors.

Copy link

Contributor Author

xuzaixian commented Mar 8, 2019

@jdneo
There is no error in my environment when i run vsce package
But The Travis CI build failed.
Can you take a look ?

@jdneo

Copy link

Member

jdneo commented Mar 8, 2019

@xuzaixian It's because the file system on Linux is case sensitive.

your file name is leetcodePreviewProvider.ts, but when you import it, you are using leetCode.

jdneo

jdneo reviewed

src/leetcodePreviewProvider.ts Outdated Show resolved Hide resolved

jdneo

jdneo reviewed

src/utils/webviewUtils.ts Outdated Show resolved Hide resolved

jdneo

jdneo reviewed

src/utils/webviewUtils.ts Outdated Show resolved Hide resolved

jdneo

jdneo reviewed

src/shared.ts Outdated Show resolved Hide resolved


 Update leetCodePreviewProvider function structure

ce66544

Move the logic in webviewUtils.ts to leetCodePreviewProvider
Fix missing semicolon
Rename leetcodePreviewProvider to leetCodePreviewProvider

xuzaixian and others added 2 commits

March 11, 2019 10:55


 Merge branch 'master' into master

cd98419

@jdneo


 minor fixes

7e2c843

jdneo

jdneo approved these changes

Mar 12, 2019