-
Notifications
You must be signed in to change notification settings - Fork 676
Add Click the tree explorer should open the topic (#132) #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@xuzaixian Thank you for contribution.
From my understanding, after applying this change, when the user clicks on the tree node, we will generate new / open existing problem file, right?
yes ~
Emm, I'm ok to open the existing problem file.
While for the non-existing file, it will be better if we can first show the problem description to the user, and generate the file if the user has some further confirmation action. What do you think?
Hum....maybe we can preview the problem within a webview , and generate the file after confirmation action ?
@xuzaixian Exactly what I'm thinking about. And this action can be bound with a new command called Preview Problem.
Would you like to have a try to implement this feature first?
ok, i will work on it.
@xuzaixian I'm thinking that if we should create a new command or just reuse Show Problem
I prefer to create a new command Preview Problem .
use 'Show Problem' when they want to code right now
use 'Preview Problem' when they want to read description.
we can provide more choices to user 🤣
@xuzaixian So what should we do when user left-click on the node?
@jdneo How about just preview the problem description when user left-click?
We can provide an extra button called Code Now or something else .. in preview window,
The user can click button to code right away.
Also provide a new menu option in right-click menu called Code Now.
This sounds convenient.
@xuzaixian Yes, sounds good
Hi @xuzaixian,
I noticed that a lot of diffs is caused by reformating the package.json. Would you mind to revert those formatting changes? This could make it easier to review.
Thanks!
e1ebd7c to
be596bd
Compare
sorry for that 😢
Remove unused function Use rem instead of px Use the VS Code embed CSS vars in Preivew Webview Use spaces instead of tabs in package.json Use previewProvider to manage preivew logic
@xuzaixian You can install an extension called: TS Lint, to help you resolve those lint errors.
https://marketplace.visualstudio.com/items?itemName=ms-vscode.vscode-typescript-tslint-plugin
@jdneo
There is no error in my environment when i run vsce package
But The Travis CI build failed.
Can you take a look ?
@xuzaixian It's because the file system on Linux is case sensitive.
your file name is leetcodePreviewProvider.ts, but when you import it, you are using leetCode.
Move the logic in webviewUtils.ts to leetCodePreviewProvider Fix missing semicolon Rename leetcodePreviewProvider to leetCodePreviewProvider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @xuzaixian for the great work!
Uh oh!
There was an error while loading. Please reload this page.
Resolve #131