-
Notifications
You must be signed in to change notification settings - Fork 677
Use internal build cli #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Let me explain more about this PR.
In this PR, I change the dependency from leetcode-cli to vsc-leetcode-cli, which is a forked privacy build of the leetcode-cli. This is due to that the latest version of leetcode-cli has some broken features and inactive for a long time. So I have to replace it with my forked version.
So far I have no plan to write a new cli tool to replace it. I'm very willing to merge back to the origin leetcode-cli when it becomes active again.
twchn
commented
Mar 3, 2019
Using a forked version of leetcode-cli is a better choice I think, we can keep in sync with the upstream(leetcode-cli), and then fix known issues ASAP or customize the extra features we need.
Try to resolve #74, #83, #103, #105
@poppinlp Please help review when you have time. Thanks!