Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: add github issue templates #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdneo merged 4 commits into LeetCode-OpenSource:master from poppinlp:issue169
Mar 3, 2019

Conversation

@poppinlp
Copy link
Contributor

@poppinlp poppinlp commented Mar 1, 2019

This PR is for #169
I've added 4 issue templates.

  • bug.md: For bug report.
  • feature.md: For feature request.
  • question.md: For question.
  • ISSUE_TEMPLATE.md: If the user chooses to create a regular issue.

- *extension settings*:
- *nodejs version*:
- *vscode version*:
- *extension version*:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, add the expected behavior and the actual behavior?

Copy link
Member

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, just some comments...

Please add the .github folder into the .vscodeignore so that we won't package the content into the *.vsix

Thanks.

Copy link
Contributor Author

poppinlp commented Mar 3, 2019

  • Add .github in .vscodeignore(sry for forgot that)
  • Add reproduce step and expected behavior in bug.md

I think we could get the information for the actual behavior from the bug description, so I just add the reproduce step and expected behavior. What do you think? :)

Copy link
Member

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdneo jdneo merged commit d3d522a into LeetCode-OpenSource:master Mar 3, 2019
@jdneo jdneo added this to the 0.12.0 milestone Mar 3, 2019
@poppinlp poppinlp deleted the issue169 branch March 4, 2019 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdneo jdneo jdneo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.12.0

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /