-
Notifications
You must be signed in to change notification settings - Fork 85
fix: Specify react and rxjs in peerDependencies #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Merging #402 into master will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #402 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 2 2 Lines 51 51 Branches 6 6 ========================================= Hits 51 51
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update d5ab3ea...9dc42c3. Read the comment docs.
hi, very thanks for your contribution, we have landed it in master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Dependencies should be specified in either
dependenciesorpeerDependenciessection ofpackage.jsonwhen accessed in production code viaimportstatements orrequires. It seems that although rxjs-hooks is importingreactandrxjsin its production code, neither of them is specified.Below is a part of the production bundle where
rxjsandreactis imported. (dist/esm/use-event-callback.js)image
This makes the library to break in environments using strict dependency management systems such as yarn v2.
This pull request fixes the issue by specifying
reactandrxjsinpeerDependenciesof package.json.