-
Notifications
You must be signed in to change notification settings - Fork 89
Conversation
prepare
commented
Mar 26, 2020
Thank you for your PR.
At this time,
The PixelFarm lib is under 'refactoring phase'.
After that => I will review this PR soon.
So many logic changes. Have you gone through all the visual demos to make sure nothing is broken?
It is not enough to be buildable.
Happypig375
commented
Mar 26, 2020
I did not try the Android/iOS demos but Windows demos work just fine.
@prepare You can pick some important APIs and make a list of them. I'd like to help adding unit tests on them. Visual correctness is quite fragile, I think.
charlesroddie
commented
May 11, 2020
@prepare I would suggest merging this in relatively fast if possible. Enabling NRTs is good hygiene and clarifies any current structure, which will only help any future refactoring. This PR represents a lot of work and conflicts will accumulate fast.
Happypig375
commented
May 29, 2020
@prepare When will this be merged? I'll fix conflicts if you confirm that this will be merged.
prepare
commented
May 29, 2020
I need to test this at least with the
PixelFarm and HtmlRenderer and agg-sharp (MatterHackers/agg-sharp#1307) too.
Happypig375
commented
Jun 8, 2020
A few days ago the amount of conflicting files could fit inside the GitHub interface. Now it is off the charts.
Happypig375
commented
Jun 21, 2020
@prepare What's the progress of testing this PR?
Happypig375
commented
Jun 23, 2020
The silence is deafening.
charlesroddie
commented
Nov 22, 2020
Note @Happypig375 :
#181 (comment)
I will remove old projects for .net2.0-3.5 in this December too.
The presence of the obsolete dotnet projects in this repo is causing a lot of the diff in this PR. I assume it won't be hard to merge any change removing these projects into this PR (the main work being the existing conflicts), since it would be mainly be deleting a lot of files. @prepare do you agree that would make this PR reviewable?
virzak
commented
Mar 5, 2021
So because #221 merged, you have to resolve now. Let me know if you need any help with it.
Happypig375
commented
Mar 6, 2021
@virzak Seems not worth the work if it's not going to be merged anyways.
Closes #191
Nullable reference types are now enabled for:
Nullable warnings from above projects will be treated as errors to ensure that nullability seen by users is truthful. If they stay as warnings, it is very possible that they will be ignored like the rest of Typography's warnings 😉 They are not enabled for PixelFarm projects - annotating them will need action from the PixelFarm repo as well.
Additional goodies:
P.S. This is probably my largest PR ever 😆 🎉