-
Notifications
You must be signed in to change notification settings - Fork 58
add methods for 13.5 minute tzait and plag hamincha based on that zman - #229
Open
Elyahu41 wants to merge 1 commit into
Open
add methods for 13.5 minute tzait and plag hamincha based on that zman #229Elyahu41 wants to merge 1 commit into
Elyahu41 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know the getTzaisGeonim13AndAHalfMinutesZmanis method has a bad history. However, I just wanted to point out that it is technically missing from the API, and there is a zman that is dependent on it. I did not make getTzaisGeonim13AndAHalfMinutesZmanis a public method so no one can use it until it is decided how to introduce the method to users of the API.
There is also getPlagHaminchaYalkutYosef, which I need to find the source for.