forked from Yandex-Practicum/Java-Module-Project-YP
-
Notifications
You must be signed in to change notification settings - Fork 0
"Проектная работа No1": передаю на ревью. #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
31 changes: 31 additions & 0 deletions
src/main/java/Car.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| public class Car { | ||
| final String carName; // final Это сделает поля неизменяемыми после инициализации. | ||
| final int raceCar; // final Это сделает поля неизменяемыми после инициализации. | ||
| public Car(String carName, int raceCar){ | ||
| this.carName = carName; | ||
| this.raceCar = raceCar; | ||
| } | ||
|
|
||
| public Car() { | ||
| this.carName = ""; | ||
| this.raceCar = 0; | ||
| } | ||
|
Comment on lines
+9
to
+12
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. этот конструктор особо не имеет смысла, поэтому лучше удалить |
||
|
|
||
| // Метод для получения названия машины | ||
| public String getCarName() { | ||
| return carName; | ||
| } | ||
|
|
||
| // Метод для получения скорости машины | ||
| public int getRaceCar() { | ||
| return raceCar; | ||
| } | ||
| /*Пометка полей как final полезна по нескольким причинам: | ||
| 1. Безопасность данных: исключается возможность случайного | ||
| изменения состояния объекта после его создания. | ||
| 2. Чистота кода: делает намерения программиста более явными и | ||
| упрощает понимание кода другими разработчиками. | ||
| 3. Оптимизация: компилятору может быть проще оптимизировать | ||
| код, если он знает, что значения полей не изменятся. | ||
| */ | ||
| } | ||
48 changes: 47 additions & 1 deletion
src/main/java/Main.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,52 @@ | ||
| import java.util.InputMismatchException; | ||
|
|
||
| import java.util.Scanner; | ||
|
|
||
| public class Main { | ||
| public static void main(String[] args) { | ||
| System.out.println("Hello world!"); | ||
| Scanner scanner = new Scanner(System.in); | ||
| Race race = new Race(); | ||
| int min = 0; | ||
| int max = 250; | ||
|
|
||
| for (int i = 0; i < 3; i++) { | ||
| System.out.println("Введите название " + (i + 1) + " автомобиля"); | ||
| String carName = scanner.next(); | ||
| while (carName.isEmpty()) { | ||
| System.out.println("Пожалуйста, введите название автомобиля."); | ||
| carName = scanner.next(); | ||
| } | ||
|
|
||
| int speed; | ||
| while (true) { // Бесконечный цикл для повторного запроса ввода | ||
| System.out.println("Введите скорость " + (i + 1) + " автомобиля (не больше 250 и не меньше 1)"); | ||
| try { | ||
| speed = scanner.nextInt(); | ||
| if (speed > min && speed <= max) { | ||
| break; | ||
| } else { | ||
| System.out.println("Ошибка, неправильно ввели скорость"); | ||
| } | ||
| } catch (InputMismatchException e) { | ||
| System.out.println("Вы ввели некорректное значение. Пожалуйста, введите целое число."); | ||
| scanner.next(); | ||
| } | ||
| } | ||
|
|
||
| // Создаем экземпляр Car с уже введенными значениями | ||
| Car car = new Car(carName, speed); | ||
|
|
||
| // Определяем текущего лидера | ||
| race.defineLeader(car); | ||
| } | ||
| scanner.close(); | ||
|
|
||
| // Выводим название машины-победителя | ||
| String winners = race.getWinnerName(); | ||
| if (winners != null) { | ||
| System.out.println("Наш победитель - самая быстрая машина: " + winners); | ||
| } else { | ||
| System.out.println("Нет данных о победителях."); | ||
| } | ||
| } | ||
| } |
19 changes: 19 additions & 0 deletions
src/main/java/Race.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
| public class Race { | ||
| private String leader = "";; | ||
| private int maxDistance = 0; | ||
| public void defineLeader(Car car){ | ||
| int newCarDistance = 24 * car.raceCar; | ||
|
|
||
| if (newCarDistance > maxDistance) { | ||
| leader = car.carName; | ||
| maxDistance = newCarDistance; | ||
| } | ||
| } | ||
|
|
||
| // Метод для получения имени победителя | ||
| public String getWinnerName() { | ||
| return leader; | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.