This repository was archived by the owner on Apr 10, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 173
Removal of array constructor ".last()" so that this project does not clash with other custom array methods#33
Open
egilll wants to merge 1 commit into
Open
Removal of array constructor ".last()" so that this project does not clash with other custom array methods #33egilll wants to merge 1 commit into
egilll wants to merge 1 commit into
Conversation
...clash with other custom array methods Some other packages, like [`array-sugar`](https://github.com/capaj/array-sugar), add new methods for arrays. When such packages are used with html2json, HTML parsing will fail because of the clash of the newly created array methods ".last" and ".last()". The proposed change removes the custom array method and uses vanilla Javascript instead. The error that will otherwise pop up is: `stack.last is not a function`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removal of array constructor ".last()" so that this project does not clash with other custom array methods.
Some other packages, like
array-sugar, add new methods for arrays.When such packages are used with html2json, HTML parsing will fail because of the clash of the newly created array methods ".last" and ".last()".
The proposed change removes the custom array method and uses vanilla Javascript instead.
The error that will otherwise pop up is:
stack.last is not a function.