-
Notifications
You must be signed in to change notification settings - Fork 40
Optimize pairwise for Sinus and scalar inputs
#538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@ ## master #538 +/- ## ========================================== - Coverage 72.78% 66.57% -6.22% ========================================== Files 52 52 Lines 1374 1382 +8 ========================================== - Hits 1000 920 -80 - Misses 374 462 +88 ☔ View full report in Codecov by Sentry. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@simsurace
simsurace
force-pushed
the
scalar-periodic
branch
from
January 23, 2024 20:21
7a88585 to
f990586
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A call like
kernelmatrix(PeriodicKernel(), rand(1000))produces a number of allocations of the same order as the size of the kernel matrix becauseSinushas a vector parameter and the dispatch hits a path which allocates that for each element of the kernel matrix.Proposed changes
We add two specialized methods that use broadcast.
What alternatives have you considered?
None.