-
Notifications
You must be signed in to change notification settings - Fork 17
Add $ref support for ComboBox + some optimization #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
add $ref support (external resource) for ComboBox
coveralls
commented
Mar 11, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work to improve the code quality and remove code duplication
Hi @almirus,
Thanks for your contribution,
Could you please update the documentation and describe the new added property ?
I do not speak English well.
Examples for $ref:
https://github.com/json-schema-form/angular-schema-form/blob/bd182950b78c68ac3556b399fbaf3e3ea9a33232/examples/data/jsonref.json
json-schema-form/json-schema-form-core#1
It may be necessary to add support $ref for all fields
I found the combo box and the check box documentation aren't published yet, so i will add this property in the doc and publish that ASAP.
Don't hesitate if you find any improvement to do
code deduplication and add $ref support for ComboBox