Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Schema Decorator #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SaifJerbi merged 6 commits into JsonSchema-JavaUI:master from Fakhreddine10:master
Jun 8, 2017
Merged

Conversation

Copy link
Member

@Fakhreddine10 Fakhreddine10 commented Jun 8, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Creating a nice solution which through we can decorate the JsonSchema dynamically. with this solution we can decorate the json schema with all annotations that we like.

Alternate Designs

I prefer the factory design pattern rather then Strategy and observator.
With strategy pattern, in the StringSchema object,we will have a tied coupling with many concrete SchemaDecorator implementation.
But with the observator pattern, the problem is we will notify all the SchemaDecorator, which we can have a performance issues

Why Should This Be In Core?

Benefits

Change JsonSchema with flexible manner

Possible Drawbacks

Applicable Issues

Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 06028b0 on Fakhreddine10:master into 5f06f37 on JsonSchema-JavaUI:master.

Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 89ac4ce on Fakhreddine10:master into 5f06f37 on JsonSchema-JavaUI:master.

Copy link
Member Author

It's ok, i will fix it

Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 148f91f on Fakhreddine10:master into 5f06f37 on JsonSchema-JavaUI:master.

Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 148f91f on Fakhreddine10:master into 5f06f37 on JsonSchema-JavaUI:master.

Copy link
Member

🎨 Good job
[ci skip]

@SaifJerbi SaifJerbi merged commit 072fd86 into JsonSchema-JavaUI:master Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /