-
Notifications
You must be signed in to change notification settings - Fork 17
Schema Decorator #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Schema Decorator #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coveralls
commented
Jun 8, 2017
coveralls
commented
Jun 8, 2017
It's ok, i will fix it
coveralls
commented
Jun 8, 2017
coveralls
commented
Jun 8, 2017
🎨 Good job
[ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Creating a nice solution which through we can decorate the JsonSchema dynamically. with this solution we can decorate the json schema with all annotations that we like.
Alternate Designs
I prefer the factory design pattern rather then Strategy and observator.
With strategy pattern, in the StringSchema object,we will have a tied coupling with many concrete SchemaDecorator implementation.
But with the observator pattern, the problem is we will notify all the SchemaDecorator, which we can have a performance issues
Why Should This Be In Core?
Benefits
Change JsonSchema with flexible manner
Possible Drawbacks
Applicable Issues