-
Notifications
You must be signed in to change notification settings - Fork 4
Comments
chore + fix: port to geode v5, remove as many tradmodder smells/outdated macros as possible#7
Open
RayDeeUx wants to merge 8 commits intoJouca:main from
Open
chore + fix: port to geode v5, remove as many tradmodder smells/outdated macros as possible #7RayDeeUx wants to merge 8 commits intoJouca:main from
RayDeeUx wants to merge 8 commits intoJouca:main from
Conversation
Owner
Jouca
commented
Feb 21, 2026
Hello,
Thanks for your PR!
I'll take a look today and check if everything works as intended!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_sprtheir node IDs in README (why wasn't this done sooner?)geode::cocos::getChild()->CCNode::getChildByIndex()[functionally equivalent]CCARRAY_FOREACHmacros for actual foreach loops based onCCArrayExtstatic_casting them nilly willystd::stoi()calls in favor ofgeode::utils::numFromStringandunwrapOr()std::transform()andstd::findcalls in favor ofgeode::utils::string::toLower()andgeode::utils::string::contains()