-
Notifications
You must be signed in to change notification settings - Fork 71
fix: empty manufacturer lead to failed parse_device_properties - #359
Open
clansty wants to merge 1 commit into
Open
fix: empty manufacturer lead to failed parse_device_properties #359clansty wants to merge 1 commit into
clansty wants to merge 1 commit into
Conversation
CloCkWeRX
commented
Feb 9, 2025
Needs #361 first
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My tv returns empty with
getprop ro.product.manufacturerimage
this leads the
.strip()removed the empty line andpropertieswill become only 4 lines._parse_device_propertieswill stop parsing.if android version is not parsed, the library will use wrong command to get state and control the device.
I added two
echo %line in the begin and end of the "get properties" command to prevent empty manufacturer to be erased by strip