-
Notifications
You must be signed in to change notification settings - Fork 1
create tools for model_summary parse and mock operators execution#2
create tools for model_summary parse and mock operators execution #2baominghelly wants to merge 1 commit into
Conversation
Chamberlain0w0
commented
Nov 24, 2025
这个 infinimetrics/tools/ 文件夹是什么定位?跟放在 infinimetrics/ 下面其他路径的 py 文件有什么关系?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
输入文件不提交到 git repo 内
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个信息最好在对应要替换的代码行上面加一个 TODO,这样清楚一些,便于之后定位
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
单元测试的部分目前感觉不是特别必要,因为逻辑都是输入输出格式的检查,但之后如果格式还有变化的话,还需要再重新改这部分
Chamberlain0w0
commented
Nov 24, 2025
我感觉还有一个点就是现在的逻辑过于"流式"了,观感上很像很多零碎的脚本。我感觉如果要形成一个"框架"的话,实现上最好还是面向对象一点,比如说负责读入的定义一个 class Parser,然后固定几个操作接口;中间定义一个 Excecutor,结果输出再定义一个 Reporter,中间涉及的一些处理过的数据也可以定义为结构化的数据,这样的话所有测试都可以用一套逻辑调用,扩展性更强,并且 main 的脚本里会显得更清楚一些。晚点可以再讨论一下。
Description
create tools for model_summary parse and mock operators execution
Test
Unit test
Test with real data