This repository was archived by the owner on Feb 24, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27
Draft
Conversation
Signed-off-by: Craig Ingram <cingram@us.ibm.com>
Signed-off-by: Craig Ingram <cingram@us.ibm.com> # Conflicts: # Dockerfile.exporter
Signed-off-by: Craig Ingram <cingram@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Varnish-modules seem to be the main issue here. I'm having to build them from source and don't think I have them working with Varnish yet (haven't tested yet but not sure how it could work). There's also one more instance of varnish 6.x getting installed.
At the end of the day it'd be nice to support varnish 6.x and 7.x, but it appears that is going to be slightly painful since this build process is so divergent. May have to make separate dockerfiles to make it work.
Signed-off-by: Craig Ingram cingram@us.ibm.com