Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Migration to Jakarta EL 4 compatible version of JUEL#915

Open
dmaidaniuk wants to merge 5 commits intoHubSpot:master from
dmaidaniuk:feature/jakarta-el-4
Open

Migration to Jakarta EL 4 compatible version of JUEL #915
dmaidaniuk wants to merge 5 commits intoHubSpot:master from
dmaidaniuk:feature/jakarta-el-4

Conversation

@dmaidaniuk
Copy link

@dmaidaniuk dmaidaniuk commented Sep 23, 2022

PR for issue #809

Please note, that here used a fork of JUEL library upgraded to Jakarta EL 4:

https://github.com/UkrSoftTech/juel/tree/jakarta-el-4

Copy link
Author

The original repo of JUEL https://github.com/beckchr/juel is not maintained since 2018. So, either the forked repo should be deployed to the Sonatype repository with a changed group id, or sources of JUEL should be included in the Jinjava library.

Copy link
Author

@jasmith-hs please take a look.

Copy link
Contributor

We will likely lean more towards including the sources into the Jinjava library like in #810
Since the original repo isn't maintained. It will be simpler to fix any bugs this way/upgrade to EL 5 if we desire that.

We could also maintain our own fork of JUEL cc @mattcoley @boulter

Copy link
Author

@jasmith-hs I can transfer ownership of https://github.com/UkrSoftTech/juel/ repository to HubSpot organization. Also, in that fork I made the migration to EL 5 on another branch https://github.com/UkrSoftTech/juel/tree/jakarta-el-5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Comments

AltStyle によって変換されたページ (->オリジナル) /