-
-
Notifications
You must be signed in to change notification settings - Fork 764
call sortChange on th click #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
call sortChange on th click #407
Conversation
First of all, thank you for your contribution. It would be great to make the whole th clickable for sortable columns. But if you have both paging and filtering, these two operations will conflict.
video
Oh, thank you. I'll fix it
What if we made just the text itself clickable for sortable columns?
Do you have any plans to merge this one? I had to do some workaround to make it clickable.
I'll try to update the PR on the next week
09552d7 to
6dbae2a
Compare
I've updated the PR
@huangshuwei could you please take a look?
@timefordroids Thank you for your contribution. It's really a nice job 👍
Sometimes it's very hard to click on sort icons to sort a table column, especially on small screens. So6 it would be great to make the whole th clickable for sortable columns.
For example: https://element.eleme.io/#/en-US/component/table#sorting