fix: virtualPhantomHeight #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

huangshuwei merged 2 commits into Happy-Coding-Clans:master from zhangjiayu1215:master

Sep 26, 2021

Merged

fix: virtualPhantomHeight #403

huangshuwei merged 2 commits into Happy-Coding-Clans:master from zhangjiayu1215:master

Sep 26, 2021

Conversation

zhangjiayu1215

Copy link

Contributor

@zhangjiayu1215 zhangjiayu1215 commented Sep 26, 2021

change virtualPhantomHeight when data is empty

@zhangjiayu1215


 fix: virtualPhantomHeight

a6c8b22

change virtualPhantomHeight when data is empty

@huangshuwei

Copy link

Collaborator

huangshuwei commented Sep 26, 2021

首先感谢你的PR。

你的代码的确修复了这个bug。如果修改为下面的方式是不是更简洁一点:

 setVirtualPhantomHeight() {
 let totalHeight = 0;
 if (this.virtualScrollPositions.length) {
 totalHeight =
 this.virtualScrollPositions[
 this.virtualScrollPositions.length - 1
 ].bottom;
 }
 this.$refs[this.virtualPhantomRef].style.height =
 totalHeight + "px";
 },