-
Notifications
You must be signed in to change notification settings - Fork 154
Comments
Fix: Black Bars Around Output Video on Custom Resolutions (#165, #180)#189
Open
AbdulWahab1539 wants to merge 2 commits intoHBiSoft:master from
Open
Fix: Black Bars Around Output Video on Custom Resolutions (#165, #180) #189AbdulWahab1539 wants to merge 2 commits intoHBiSoft:master from
AbdulWahab1539 wants to merge 2 commits intoHBiSoft:master from
Conversation
... custom resolution Changed resolution settings from dimensions to actual resolution options
Added comments and function docs for better understanding what the function does and parameters it takes. new setResolution function documentation added in Readme
Owner
HBiSoft
commented
May 28, 2025
Thank you for this. I will review it today, test it on my side, and then implement it. I'm sorry for only responding now.
Author
AbdulWahab1539
commented
May 28, 2025
Thank you for getting back to me! I really appreciate it. I’m glad to hear you’ll be reviewing it soon. If there are any changes or improvements you’d like to see, I’d be happy to update the contribution accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where selecting a custom resolution preset from settings results in black bars or padding around the output video on various devices. The fix ensures that the video maintains the correct aspect ratio without unwanted padding.
Changes
Related Issues
Testing
Verified on multiple devices with different aspect ratios. Here is the list
Ensured recorded videos match the selected resolution without additional padding/black bars.
Let me know if you need refinements! 🚀. I hope my PR gets merged.