-
Notifications
You must be signed in to change notification settings - Fork 0
Field fixes: confirm on remove-round; timer row live after add - #501
Merged
Merged
Field fixes: confirm on remove-round; timer row live after add #501ryan-johnson2 merged 2 commits into
ryan-johnson2 merged 2 commits into
Conversation
...row after add (#500) #499: since #439 removing a round discards its Scheduled heats by design — the un-confirmed one-click Remove was a stray click from losing a schedule. Two-step ConfirmButton now. #500: the #462 auto-dial lands on the reconciler sweep AFTER the add's reload snapshot, so the screen saw no hold, never started its hold-poll, and the row sat stale until nav-away-and-back. One delayed quiet refresh (2.5s) sees the auto-hold land and the hold-poll takes over; 'Connecting' also keeps the poll alive on its own. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ryan-johnson2
force-pushed
the
fix-499-500
branch
from
August 29, 2026 01:07
7e64df0 to
1e4fa77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two findings from Ryan's desktop session, both tested through the real screens.
#499 — Remove round is destructive since #439 (discards Scheduled heats); it now takes the console's standard two-step confirm. Test drives arm → cancel → arm → confirm.
#500 — after add, the #462 auto-dial connected but the page never re-read (the self-poll keyed off a snapshot taken before the reconciler's sweep granted the hold). One delayed refresh catches the hold; 'Connecting' keeps the poll alive. Regression test drives the real add dialog and asserts the second look lands unaided.
Fixes #499. Fixes #500.
🤖 Generated with Claude Code