-
-
Notifications
You must be signed in to change notification settings - Fork 96
Error message hard to read #938#985
Error message hard to read #938 #985abdullah-maher-abbod wants to merge 2 commits intoGreenstand:master from
Conversation
@EngrTaofeek
EngrTaofeek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally when making changes to the user interface you could add a screenshot or screen recording of the effect of the change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to add this comment. Github automatically the lines and file you made changes to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this was on the first commit, i was trying learn how deal with github.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
Elforama
commented
Jul 6, 2022
I'm not sure this issue was talking about the button text. I think it was referring to the black error text showing in the red box. I think this should be decided by design before committing to a change though. @EngrTaofeek can you confirm with design on this task please?
@Elforama Yes, this changing the black error text in the red box as it shown below:
although still not sure because i might need to change for this issues (Country code in the phone number needed to make unique wallet)
Fixes #938
-Change the Text color to White
-add an example for the User