-
Notifications
You must be signed in to change notification settings - Fork 3
Merged
Conversation
@chyalexcheng
Copy link
Copy Markdown
@chyalexcheng
chyalexcheng
commented
Nov 30, 2023
Contributor
- merge branch load_all
- use seaborn to plot statistics and show distributions
Retiefasaurus
Retiefasaurus
approved these changes
Nov 30, 2023
@Retiefasaurus
Retiefasaurus
left a comment
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good. Seaborn is a nice addition to the plotting functionality. See comment on pyproject.toml.
dev = ["pytest", "pytest-cov", "prospector", "pyroma", "h5py"]
rnn = ["wandb", "tensorflow"]
tutorials = ["ipykernel"]
visuals = ["seaborn"]
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should add pandas to visuals? It is used in ```plot_pdf`` function.
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so, although pandas got installed automatically when installing seaborn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.