-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
* Linking to dem (#47) * remove pylint from pyproject.toml * linking to YADE (two particle collision) * linking to YADE (triaxial compression)
Kudos, SonarCloud Quality Gate passed! Quality Gate passed
Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells
@Retiefasaurus
Retiefasaurus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its great that you have Yade included into GL. Approving the review for now. Here are some recommendations I have for the future
- Use standardized data format for IO modules.
- Improve documentation for IO modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks alright so far. Just want to check if there are documentation on the specific format needed for the IO?
Future - Do you think it would be useful to experiment with other format types? https://aaltoscicomp.github.io/python-for-scicomp/data-formats/ (see table)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Future - It would be useful to have poetry groups: isolating specific packages if a user wants to use only certain parts of GL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows build is failing due to some dependencies from tensor flow, seems like it has to do with filesystem issues.
No description provided.