-
-
Notifications
You must be signed in to change notification settings - Fork 94
as stock, upon exception show message box and kill discord.#160
Open
Skamt wants to merge 1 commit into
Open
Conversation
CanadaHonk
commented
Jan 25, 2024
Contributor
This shouldn't use try catch, instead use process on uncaught exception/etc
Skamt
commented
Jan 28, 2024
Author
without the renderer's dedicated try catch, if something breaks early the update's try catch catches it and discord gets stuck in the splash checking for updates.
it would require a lot more changes to remedy this, and i try to keep my PR as small as possible, if you think this change is no good, you can close the PR no problem :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
turns out when the renderer process crashes nothing happens and it stays running in the background, as OA is missing exception handling around the renderer like in stock discord.