-
Notifications
You must be signed in to change notification settings - Fork 31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request attempts to upgrade the Go version to 1.26 and Delve to 1.26.1 across the helper image, Skaffold configuration, and integration tests. However, multiple critical issues were identified because Go 1.26 and Delve 1.26.1 are not currently existing or valid versions. These changes will cause the Docker build to fail as the base images and source archives cannot be retrieved. The feedback recommends using a valid Go version, such as 1.25 or a patch update for 1.24, and updating all associated test manifests and labels accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go version 1.26 is not a valid or existing version. The current stable release is 1.24. This will cause the build to fail as the base image golang:1.26 cannot be pulled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delve version 1.26.1 does not exist (current versions are ~1.24.x). The build will fail at line 19 when attempting to download the source archive from GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using Go version 1.26 here is inconsistent with available Go releases and skips version 1.25. If the intention was to add the next supported version, it should likely be 1.25 or a patch update for 1.24.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The naming convention and labels throughout this file use go126, which corresponds to the non-existent Go version 1.26. This file should be updated to reflect a valid Go version.
Same as #147 , but with support for Golang 1.26