Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

chore: bump sigs.k8s.io/kind from 0.30.0 to 0.31.0 #1966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Camila-B wants to merge 2 commits into GoogleContainerTools:main
base: main
Choose a base branch
Loading
from Camila-B:update-kind

Conversation

@Camila-B
Copy link
Contributor

@Camila-B Camila-B commented Dec 18, 2025

No description provided.

Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from camila-b. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor Author

/test all

Copy link

Summary of Changes

Hello @Camila-B, I'm Gemini Code Assist1 ! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on upgrading the sigs.k8s.io/kind dependency to its 0.31.0 release. This update integrates the latest changes from the Kind project, which includes updated default images for Kubernetes nodes and other core components, as well as refinements in how certain Kubernetes features are configured during cluster provisioning. Additionally, the change adjusts the retry logic for e2e tests and improves IPv6 error detection within the Kind Docker provider.

Highlights

  • Kind Dependency Update: The sigs.k8s.io/kind dependency has been bumped from version 0.30.0 to 0.31.0, incorporating the latest features and fixes from the Kind project.
  • Kind Cluster Configuration Streamlining: Explicit configuration for MutatingAdmissionPolicy feature gates and runtime settings has been removed from Kind cluster creation, suggesting these are now handled by default or in a more streamlined manner by the updated Kind version.
  • E2E Test Efficiency: The maxKindTries constant, which determines the number of attempts to create a Kind cluster for e2e tests, has been reduced from 6 to 2, potentially speeding up test failures in case of cluster creation issues.
  • Internal Kind Component Updates: Various internal images used by Kind, including the default Kubernetes node image (kindest/node), CNI (kindnetd), storage provisioner (local-path-provisioner), storage helper (local-path-helper), base image (kindest/base), and load balancer (kindest/haproxy), have been updated to newer versions.
  • Improved IPv6 Error Handling: The Kind Docker provider now includes an additional check for dockerIPV6PolicyError when determining IPv6 unavailability, enhancing error detection for IPv6-related issues.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps the sigs.k8s.io/kind dependency from version 0.30.0 to 0.31.0. The changes primarily consist of updating the vendored code and adjusting the e2e test setup to be compatible with the new version. One notable change is the reduction of cluster creation retries in the tests, which could potentially affect test stability. Overall, the dependency update is handled correctly.

// maxKindTries is the number of times to attempt to create a Kind cluster for
// a single test.
maxKindTries = 6
maxKindTries = 2
Copy link

@gemini-code-assist gemini-code-assist bot Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Reducing maxKindTries from 6 to 2 could potentially increase test flakiness if KinD cluster creation is not perfectly reliable. If cluster creation failures are still possible, it might be safer to keep a higher number of retries to ensure test stability. Consider reverting this change or monitoring test results closely for any increase in flakes related to cluster creation.

Suggested change
maxKindTries = 2
maxKindTries = 6

Copy link
Contributor

Reading a bit more in the release note and see explicitly set apiVersion: kubeadm.k8s.io/v1beta3 https://github.com/kubernetes-sigs/kind/releases/tag/v0.31.0

Camila-B reacted with thumbs up emoji 

Bumps [sigs.k8s.io/kind](https://github.com/kubernetes-sigs/kind) from 0.30.0 to 0.31.0.
- [Release notes](https://github.com/kubernetes-sigs/kind/releases)
- [Commits](kubernetes-sigs/kind@v0.30.0...v0.31.0)
---
updated-dependencies:
- dependency-name: sigs.k8s.io/kind
 dependency-version: 0.31.0
 dependency-type: direct:production
 update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Copy link
Contributor Author

/retest

Copy link
Contributor Author

/retest

Copy link

@Camila-B: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kpt-config-sync-presubmit-e2e-multi-repo-test-group2 6b435cd link true /test kpt-config-sync-presubmit-e2e-multi-repo-test-group2
kpt-config-sync-presubmit-e2e-multi-repo-test-group3 6b435cd link true /test kpt-config-sync-presubmit-e2e-multi-repo-test-group3
kpt-config-sync-presubmit-e2e-multi-repo-test-group1 6b435cd link true /test kpt-config-sync-presubmit-e2e-multi-repo-test-group1
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

tiffanny29631 commented Jan 6, 2026 •
edited
Loading

The error is a bit more complicated telling by the artifacts, e.g. http://shortn/_nMbnk5LVVP. We might need to update how the kind is configured in Config Sync. https://github.com/GoogleContainerTools/config-sync/blob/v1.23/e2e/nomostest/clusters/kind.go#L155-L157 is the key.

Copy link
Contributor Author

Camila-B commented Jan 6, 2026 •
edited
Loading

Yeah it seems that config_path is now recommended https://github.com/containerd/containerd/blob/main/docs/cri/registry.md

tiffanny29631 reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /