Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Fixes hashicorp/terraform-provider-google#27300#17940

Open
nimam wants to merge 1 commit into
GoogleCloudPlatform:main from
nimam:fix_rule_update
Open

Fixes hashicorp/terraform-provider-google#27300 #17940
nimam wants to merge 1 commit into
GoogleCloudPlatform:main from
nimam:fix_rule_update

Conversation

@nimam

@nimam nimam commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Update Chronicle Rule test was missing a dependency between Rule and DataAccessScope.
This was causing errors during deletion phase of the test.

Fixes hashicorp/terraform-provider-google#27300 

chronicle: fixed update tests in `google_chronicle_rule`

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 2ea9dad:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 1 insertion(+)
google-beta provider View Diff 1 file changed, 1 insertion(+)

Test report

Analytics

Total Tests Passed Skipped Affected
43 41 1 1
Affected Service Packages
  • chronicle

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccChronicleRule_chronicleRuleBasicExample_update

View the replaying VCR build log

Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log ✅ TestAccChronicleRule_chronicleRuleBasicExample_update

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@nimam, @c2thorn, @ankitgoyal0301 VCR tests complete for 2ea9dad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@c2thorn c2thorn Awaiting requested review from c2thorn

@ankitgoyal0301 ankitgoyal0301 Awaiting requested review from ankitgoyal0301

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccChronicleRule_chronicleRuleBasicExample_update

AltStyle によって変換されたページ (->オリジナル) /