Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat: add support to networkRules on authzPolicy#17777

Merged
melinath merged 12 commits into
GoogleCloudPlatform:main from
victorsantos-cit:feat/add-networkRules-support-on-AuthzPolicy
Jun 12, 2026
Merged

feat: add support to networkRules on authzPolicy #17777
melinath merged 12 commits into
GoogleCloudPlatform:main from
victorsantos-cit:feat/add-networkRules-support-on-AuthzPolicy

Conversation

@victorsantos-cit

@victorsantos-cit victorsantos-cit commented Jun 1, 2026 •
edited by melinath
Loading

Copy link
Copy Markdown
Contributor

Hello Folks, this PR is to add a support to networkRules field on google_network_security_authz_policy resource

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

networksecurity: added `network_rules` field on `google_network_security_authz_policy` resource

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jun 1, 2026

github-actions Bot commented Jun 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jun 1, 2026

This comment was marked as outdated.

@BBBmau BBBmau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we get the following error currently:

Error recording tests:
error running go: exit status 1
stdout:
=== RUN TestAccNetworkSecurityAuthzPolicy_networkSecurityAuthzPolicyWithNetworkRulesExample
=== PAUSE TestAccNetworkSecurityAuthzPolicy_networkSecurityAuthzPolicyWithNetworkRulesExample
=== CONT TestAccNetworkSecurityAuthzPolicy_networkSecurityAuthzPolicyWithNetworkRulesExample
 resource_network_security_authz_policy_generated_test.go:433: Step 1/3 error: Error running apply: exit status 1
 
 Error: Error waiting to create AuthzPolicy: Error waiting for Creating AuthzPolicy: Error code 13, message: an internal error has occurred
 
 with google_network_security_authz_policy.default,
 on terraform_plugin_test.tf line 80, in resource "google_network_security_authz_policy" "default":
 80: resource "google_network_security_authz_policy" "default" {
 
--- FAIL: TestAccNetworkSecurityAuthzPolicy_networkSecurityAuthzPolicyWithNetworkRulesExample (172.11s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-google-beta/google-beta/services/networksecurity	172.189s
FAIL
stderr:

also we should be extensive with networkRules since it contains a massive amount of new fields

Copy link
Copy Markdown
Contributor Author

@BBBmau do you have any kind of ideia , about this error, because, local is working

Copy link
Copy Markdown
Contributor Author

@BBBmau Hey bbb, just update you, this feature, its prevent to rollout on this final weekend but broken, in on contact tto discovery more update
BBBmau reacted with thumbs up emoji 

Updated descriptions and properties in AuthzPolicy.yaml to clarify matching criteria for operations, headers, and ports.
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jun 2, 2026

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor Author

@BBBmau Just update you, this feature have a small bug and the Google Team will rollout a update to fixed that

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Copy Markdown
Contributor Author

@BBBmau, just update you, on local now works and the fix is update now, could you please push again on the queue

This comment was marked as outdated.

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jun 5, 2026

This comment was marked as outdated.

@BBBmau BBBmau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are passing but we still have multiple fields missing based on the test report. can you create new tests that run each case in order to test the new fields thoroughyl?

Copy link
Copy Markdown
Contributor Author

tests are passing but we still have multiple fields missing based on the test report. can you create new tests that run each case in order to test the new fields thoroughyl?

Sorry to daley, i will create another test, using this fields right now

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jun 9, 2026

This comment was marked as outdated.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jun 9, 2026

This comment was marked as outdated.

This comment was marked as outdated.

@github-actions github-actions Bot requested review from slevenick and removed request for BBBmau June 12, 2026 18:33

Copy link
Copy Markdown
Member

@modular-magician reassign-reviewer melinath

@github-actions github-actions Bot requested review from melinath and removed request for slevenick June 12, 2026 18:33
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jun 12, 2026

modular-magician commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a053aa8:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 3 files changed, 1854 insertions(+), 669 deletions(-)
google-beta provider View Diff 4 files changed, 2036 insertions(+), 669 deletions(-)
terraform-google-conversion View Diff 4 files changed, 1338 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
83 75 7 1
Affected Service Packages
  • networksecurity

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccNetworkSecurityAuthzPolicy_networkSecurityAuthzPolicyWithNetworkRulesExample

View the replaying VCR build log

Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log ✅ TestAccNetworkSecurityAuthzPolicy_networkSecurityAuthzPolicyWithNetworkRulesExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@victorsantos-cit, @melinath VCR tests complete for a053aa8!

@melinath melinath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting all the fields included in the tests! Could you also add an update test for this? The easiest way would probably be to convert this resource to use "samples", which can generate update tests.

Migration guide: https://googlecloudplatform.github.io/magic-modules/reference/update-test-changes/
Reference: https://googlecloudplatform.github.io/magic-modules/reference/sample/

Basically we'd want all the new updatable fields to be updated in the test, just to exercise that process.

Copy link
Copy Markdown
Contributor Author

Sure, lets create this

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jun 12, 2026

modular-magician commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 96f66c7:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 3 files changed, 1854 insertions(+), 669 deletions(-)
google-beta provider View Diff 4 files changed, 2078 insertions(+), 669 deletions(-)
terraform-google-conversion View Diff 4 files changed, 1338 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
83 75 7 1
Affected Service Packages
  • networksecurity

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccNetworkSecurityAuthzPolicy_networkSecurityAuthzPolicyNetworkRulesExample

View the replaying VCR build log

Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log ✅ TestAccNetworkSecurityAuthzPolicy_networkSecurityAuthzPolicyNetworkRulesExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@victorsantos-cit, @melinath, @BBBmau VCR tests complete for 96f66c7!

@melinath melinath left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - there are a couple fields that aren't exercised in the update tests, but they have sibling fields which are. There are also some nits (we don't usually want to support UNSPECIFIED fields, but they slip through occasionally; it's not the end of the world.) Overall I think this is good enough.

@melinath melinath added this pull request to the merge queue Jun 12, 2026

Copy link
Copy Markdown
Member

Copy link
Copy Markdown
Member

(you won't have access to that)

Copy link
Copy Markdown
Member

ah, the test is beta-only; created #17960 to double-check if it can be turned on in GA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@melinath melinath melinath approved these changes

@BBBmau BBBmau Awaiting requested review from BBBmau

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /