-
Notifications
You must be signed in to change notification settings - Fork 42
Better connection exception reporting and small changes #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...h to avoid time zone calculations
...h to avoid time zone calculations
Codecov Report
@@ Coverage Diff @@ ## master #6 +/- ## =========================================== - Coverage 79.25% 58.67% -20.58% =========================================== Files 71 72 +1 Lines 988 1014 +26 Branches 229 237 +8 =========================================== - Hits 783 595 -188 - Misses 67 326 +259 + Partials 138 93 -45
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this should be linked to https://jitpack.io/#goodforgod/java-etherscan-api as other links too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the point to check for status & message if you only consider result field in the end?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private final it should be
Hello and thanks for PR and improvements!
It looks easier for me to merge and change all myself.
Partly merged via cherry pick
Hi, I added
Also fixed the Travis link on the README.md