Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix error on parameters being an object instead of an array #3623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
conico974 wants to merge 1 commit into main
base: main
Choose a base branch
Loading
from conico/rnd-7599-openapi-params
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/react-openapi/src/OpenAPICodeSample.tsx
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,11 @@ function generateCodeSamples(props: {
const searchParams = new URLSearchParams();
const headersObject: { [k: string]: string } = {};

data.operation.parameters?.forEach((param) => {
// The parser can sometimes returns invalid parameters (an object instead of an array).
// It should get fixed in scalar, but in the meantime we just ignore the parameters in that case.
const params = Array.isArray(data.operation.parameters) ? data.operation.parameters : [];

params.forEach((param) => {
if (!param) {
return;
}
Expand Down
19 changes: 11 additions & 8 deletions packages/react-openapi/src/OpenAPISpec.tsx
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,19 +117,22 @@ function getParameterGroupName(paramIn: string, context: OpenAPIClientContext):
/** Deduplicate parameters by name and in.
* Some specs have both parameters define at path and operation level.
* We only want to display one of them.
* Parameters can have the wrong type (object instead of array) sometimes, we just return an empty array in that case.
*/
function deduplicateParameters(parameters: OpenAPI.Parameters): OpenAPI.Parameters {
const seen = new Set();

return parameters.filter((param) => {
const key = `${param.name}:${param.in}`;
return Array.isArray(parameters)
? parameters.filter((param) => {
const key = `${param.name}:${param.in}`;

if (seen.has(key)) {
return false;
}
if (seen.has(key)) {
return false;
}

seen.add(key);
seen.add(key);

return true;
});
return true;
})
: [];
}

AltStyle によって変換されたページ (->オリジナル) /