Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add "original" color step and apply to bg-primary-solid elements #3618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zenoachtig merged 1 commit into main from add-bg-primary-original
Sep 2, 2025

Conversation

Copy link
Contributor

@zenoachtig zenoachtig commented Sep 2, 2025
edited
Loading

For our colour system, we standardise on perceived brightness in order to have readable contrast no matter which colour you pick.

We have an exception for step 9 of the scale (which is used for the main branding elements, like buttons or primary text) to use the chosen colour exactly unless it is wildly off the mark in terms of readability. In some cases, specifically shades of yellow, the contrast is often too low and is replaced with a more contrasting colour. This results in some pretty dark-looking UI elements for buttons and steppers.

This PR introduces an extra colour step for backgrounds, bg-*-original, which will always be the originally chosen colour. The existing bg-*-solid remains available for use cases where the colour should be guaranteed to be readable.

CleanShot 2025年09月02日 at 14 35 35@2x CleanShot 2025年09月02日 at 14 35 44@2x

Copy link

changeset-bot bot commented Sep 2, 2025

🦋 Changeset detected

Latest commit: f953585

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@gitbook/colors Minor
gitbook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

argos-ci bot commented Sep 2, 2025
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v2 (Inspect) 👍 Changes approved 3 changed Sep 2, 2025, 12:41 PM
v2-cloudflare (Inspect) 👍 Changes approved 1 changed Sep 2, 2025, 12:45 PM
v2-vercel (Inspect) ✅ No changes detected - Sep 2, 2025, 12:44 PM

@zenoachtig zenoachtig merged commit 17dd382 into main Sep 2, 2025
16 checks passed
@zenoachtig zenoachtig deleted the add-bg-primary-original branch September 2, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregberge gregberge gregberge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /