Skip to content

Navigation Menu

Sign in
Sign up

Alternative fix fonts issue in printing - #156

Open
hoon-dialog wants to merge 2 commits into
FranckFreiburger:master from
hoon-dialog:master
Open

Alternative fix fonts issue in printing #156
hoon-dialog wants to merge 2 commits into
FranckFreiburger:master from
hoon-dialog:master

Conversation

@hoon-dialog

@hoon-dialog hoon-dialog commented May 27, 2019
edited
Loading

Copy link
Copy Markdown

Unfortunately #130 prints the whole web page for me rather than just the PDF. This method renders in the original document first and copies to the iframe. Inefficient, but effective.

Fixes #66

newnewcoder, zealot128, aquinotgr00, leocnp, and cdk0507 reacted with thumbs up emoji
Henry Oon added 2 commits May 27, 2019 17:50

v1r0x commented Jul 4, 2019
edited
Loading

Copy link
Copy Markdown

Thanks for this PR! It fixes a problem for me with unicode placeholder elements instead of the correct font character rendered in the resulted print (using ubuntus 'print to file' function).
Performance seems ok to me, not much different to the current implementation in master. Don't know if there are any other caveats or disadvantages with this solution.

👍 from me :)

hoon-dialog, dvomaks, opfertunes, zealot128, robertfausk, leocnp, cdk0507, and Rookie-liu reacted with thumbs up emoji

Copy link
Copy Markdown

This also fixes a "missing font" issue in the print() function...

newnewcoder, FossPrime, JPEnterprise, robertfausk, leocnp, and cdk0507 reacted with thumbs up emoji

Copy link
Copy Markdown

请问一下 插件支持滚动翻页吗

Copy link
Copy Markdown

any reason this fix not merged with the main repo ?

leocnp, bgrand-ch, and cdk0507 reacted with confused emoji

Copy link
Copy Markdown

I'm also very interested in this PR getting merged since I'm currently relying on a fork with this fix for getting PDF printing to work :-)

cdk0507 and asyncTime reacted with thumbs up emoji

Copy link
Copy Markdown

+1

Copy link
Copy Markdown

+1

2 similar comments

Copy link
Copy Markdown

+1

cdk0507 commented Feb 14, 2022

Copy link
Copy Markdown

+1

Copy link
Copy Markdown

good

arnebm added a commit to Brendan-MacKenzie/vue-pdf that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Printing messes with the fonts

AltStyle によって変換されたページ (->オリジナル) /