-
Notifications
You must be signed in to change notification settings - Fork 25
Draft
Conversation
@JohnAZoidberg
JohnAZoidberg
requested review from
amstan,
kiram9 and
quinchou77
October 9, 2025 00:27
This will help us figure out what's going on when a BIOS update fails. Different updates return different values. Signed-off-by: Daniel Schaefer <dhs@frame.work>
@JohnAZoidberg
JohnAZoidberg
force-pushed
the
esrt-update-errors
branch
from
October 9, 2025 00:37
9cd69c8 to
0ce1c12
Compare
Member
Author
Ahhh I don't get LastAttempt status on windows yet... Need to figure out how to do that, hopefully it's possible.
Member
Author
JohnAZoidberg
commented
Oct 9, 2025
Device Manager shows:
- "Firmware resource lowest supported version"
- "Firmware resource type"
but not the last attempt version and status.
Member
Author
JohnAZoidberg
commented
Oct 9, 2025
Ahhh I don't get LastAttempt status on windows yet... Need to figure out how to do that, hopefully it's possible.
Done #220
#[derive(Debug)]
#[repr(u32)]
pub enum IntelRetimerUpdateErr {
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These might be slightly difference on different retimer generations.
Member
Author
JohnAZoidberg
commented
Oct 19, 2025
Have to double-check if our BIOS actually reports that in the ESRT status.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will help us figure out what's going on when a BIOS update fails.
Different updates return different values.