-
Notifications
You must be signed in to change notification settings - Fork 25
feat(Utils): Add signature verification utility function - #81
Open
jhodges10 wants to merge 3 commits into
Open
Conversation
@jhodges10
jhodges10
changed the title
(削除) Add signature verification util (削除ここまで)
(追記) WIP Add signature verification util (追記ここまで)
Jun 20, 2021
jhodges10
force-pushed
the
jh/add-signature-verification-util
branch
from
July 30, 2021 04:18
4d883c6 to
a74dbfd
Compare
@jhodges10
jhodges10
changed the title
(削除) WIP Add signature verification util (削除ここまで)
(追記) feat(Utils): Add signature verification utility function (追記ここまで)
Aug 3, 2021
Open
lezoudali
lezoudali
approved these changes
Dec 2, 2021
@lezoudali
lezoudali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. as long as you've tested and it works as expected. I'd add some tests? 🤔
Co-authored-by: Lezou Dali <lezou.dali@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
DEVREL-558
What I'm doing
Tests