Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add async operations to serializer. Add ability to get read or write streams from IFileStorage #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ejsmith wants to merge 4 commits into main
base: main
Choose a base branch
Loading
from feature/async-serialization

Conversation

@ejsmith
Copy link
Contributor

@ejsmith ejsmith commented Feb 1, 2021

No description provided.

Copy link
Contributor Author

ejsmith commented Feb 1, 2021

@benaadams what do you think about these changes?

Copy link

I wasn't sure what changing the interface would do compat wise and if that would be a problem :)

For the file interface is there a problem with some of the file providers as they have upload blob type implementations rather than stream based?

Copy link
Contributor Author

ejsmith commented Feb 1, 2021

Generally, I just try to keep source compat which we can do with extension methods.

Yeah, I think we can make the blob based file providers that require a single PUT operations work one way or another. Worst case scenario we can return a memorystream that on dispose does the blob PUT operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /