Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Updates element argument type in react-ssr-prepass.d.ts #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheSonOfThomp wants to merge 1 commit into FormidableLabs:master
base: master
Choose a base branch
Loading
from TheSonOfThomp:thesonofthomp/react-element-ts

Conversation

Copy link

@TheSonOfThomp TheSonOfThomp commented Apr 21, 2023
edited
Loading

Resolves #86

The type defined in Flow did not match the Typescript equivalent in @types/react. I've updated the .d.ts file to reference the correct TS type

// src/element.js
export type UserElement = {
 type: ComponentType<DefaultProps> & ComponentStatics,
 props: DefaultProps,
 $$typeof: typeof REACT_ELEMENT_TYPE
}
// @types/react 
interface ReactElement<P = any, T extends string | JSXElementConstructor<any> = string | JSXElementConstructor<any>> {
 type: T;
 props: P;
 key: Key | null;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Visitor callback element argument is typed incorrectly in TypeScript
1 participant

AltStyle によって変換されたページ (->オリジナル) /