-
Notifications
You must be signed in to change notification settings - Fork 12
Open
Conversation
puchka
puchka
suggested changes
Apr 10, 2024
@puchka
puchka
left a comment
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got this error while testing the hot reloading feature
Exception in thread "async-dispatch-1" java.lang.NullPointerException: Cannot invoke "clojure.lang.IFn.invoke()" because "this.restart_fn" is null
at xiana.hotreload$hotreload$fn__11268$state_machine__8002__auto____11285$fn__11287$fn__11289.invoke(hotreload.clj:42)
at xiana.hotreload$hotreload$fn__11268$state_machine__8002__auto____11285$fn__11287.invoke(hotreload.clj:38)
at xiana.hotreload$hotreload$fn__11268$state_machine__8002__auto____11285.invoke(hotreload.clj:38)
at clojure.core.async.impl.ioc_macros$run_state_machine.invokeStatic(ioc_macros.clj:978)
at clojure.core.async.impl.ioc_macros$run_state_machine.invoke(ioc_macros.clj:977)
at clojure.core.async.impl.ioc_macros$run_state_machine_wrapped.invokeStatic(ioc_macros.clj:982)
at clojure.core.async.impl.ioc_macros$run_state_machine_wrapped.invoke(ioc_macros.clj:980)
at xiana.hotreload$hotreload$fn__11268.invoke(hotreload.clj:38)
at clojure.lang.AFn.run(AFn.java:22)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at clojure.core.async.impl.concurrent$counted_thread_factory$reify__1774$fn__1775.invoke(concurrent.clj:29)
at clojure.lang.AFn.run(AFn.java:22)
at java.base/java.lang.Thread.run(Thread.java:833)
I made a minimal reproducible example here: https://github.com/puchka/hello-xiana/tree/test/hotreload
Co-authored-by: A. Marius Rabenarivo <mariusrabenarivo@gmail.com>
@gmsvalente
gmsvalente
force-pushed
the
feature/hotreload
branch
from
April 18, 2024 14:30
e2e9379 to
906f08a
Compare
jiriknesl
commented
Jun 3, 2024
Why is this still open? Can we finish it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Xiana hotreload/livereload
Description
This PR adds a Hotreload/Livereload to Xiana.
Tester info
Check if server is restarted when saving changes.
Completion Checklist