-
Notifications
You must be signed in to change notification settings - Fork 12
Open
Conversation
This was referenced Sep 21, 2022
soulflyer
commented
Sep 22, 2022
Contributor
Running the framework tests with ./script/auto.sh -y tests I get 4 failures in config-test. Looks like something to do with ports set in config:
soulflyer
commented
Sep 22, 2022
Contributor
Testing xiana.config-test
FAIL in (override-with-map) (config_test.clj:44)
expected: (= 5000 (get-in config [:xiana/web-server :port]))
actual: (not (= 5000 3333))
FAIL in (override-with-map) (config_test.clj:45)
expected: (= {:join? false, :port 5000} (get-in config [:xiana/web-server]))
actual: (not (= {:join? false, :port 5000} {:port 3333, :join? false}))
FAIL in (override-with-map) (config_test.clj:47)
expected: (= {:dbname "framework", :dbtype "postgresql", :host "localhost", :image-name "postgres:14-alpine", :password "postgres", :port 5432, :user "Nobody"} (get-in config [:xiana/postgresql]))
actual: (not (= {:dbname "framework", :dbtype "postgresql", :host "localhost", :image-name "postgres:14-alpine", :password "postgres", :port 5432, :user "Nobody"} {:image-name "postgres:14-alpine", :port 5432, :dbname "framework", :host "localhost", :dbtype "postgresql", :user "postgres", :password "postgres"}))
FAIL in (override-with-map) (config_test.clj:55)
expected: (= {:host "", :user "", :pass "", :tls true, :port 587, :from "xiana@"} (get-in config [:xiana/emails]))
actual: (not (= {:host "", :user "", :pass "", :tls true, :port 587, :from "xiana@"} {:host "", :user "", :pass "", :tls true, :port 587, :from ""}))
soulflyer
soulflyer
approved these changes
Sep 23, 2022
@soulflyer
soulflyer
left a comment
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title:
Description
Remove direct dependency of test-containers, move it to the examples where it is necessary
Tester info
framework tests and example tests must be fine
Completion Checklist