-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix: improve converter tool mappings and drop redundant tool guidance#358
fix: improve converter tool mappings and drop redundant tool guidance #358tmchow wants to merge 1 commit into
Conversation
- Add shared composeAgentBody utility for consistent agent body rendering - Add mapToolSpecifiers and resolveStructuredAgentTools for structured tool conversion across Copilot, Droid, and Kiro converters - Remove advisory "Tool guidance" sections from Codex converter since the skill body already carries tool restriction contracts - Remove phantom task tool mappings (TaskCreate/TaskUpdate/TaskList/ TaskGet) that solve a problem that doesn't exist in practice - Parse and pass through agent tools from Claude plugin manifests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 80ce5a60f7
i️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2 Badge Narrow Kiro tool rewrite to avoid generic "task to" text
Using a case-insensitive pattern here causes ordinary prose to be rewritten as if it were a tool reference, because task is now matched in any casing whenever it is followed by to. In converted prompts, sentences like "the next task to complete..." become "the next use_subagent to complete...", which corrupts instructions and can materially change agent behavior. This regression appears in the new lowercase mapping + gi regex combination and should be constrained to explicit tool-invocation phrasing.
Useful? React with 👍 / 👎.
Summary
composeAgentBodyutility for consistent agent body rendering across convertersmapToolSpecifiersandresolveStructuredAgentToolsfor structured tool conversion in Copilot, Droid, and Kirotoolsfrom Claude plugin manifestsTest plan
bun test— all 372 converter tests passtodotool name