-
Notifications
You must be signed in to change notification settings - Fork 15
Open
Conversation
Contributor
Hi @yeti107 thank you for this PR. I hope this feedback is useful:
Missing functionality:
- I think your PR does not detect new or cancelled sessions.
Schedule change notifications:
- Schedule updates should mention if the title or speakers change.
- Schedule updates should always include the speaker, title, time and room. Users might be interested in "Hynek's talk" or "The talk right after lunch" without remembering the title.
- Room changes should be formatted for humans, not machines. Example: "Room changed: S1 -> S1, S2"
- Start time and duration should be treated as a single piece of information. Example: "Time changed: Thu 13:00 - 13:30 -> Fri 14:00 -> 14:30".
- The date and time formatting should be programmed explicitly, instead of relying on the server's locale.
Implementation
ProgrammeConnector.fetch_schedule()should fetch the schedule. It should not return a list of schedule changes.Cog.fetch_schedule()should fetch the schedule. It should not send messages about schedule changes.- I don't think this PR should modify
mock_schedule.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bot now ...
Method/Implementation
-Added ScheduleChange model for changed sessions
-Added schedule comparison logic in ProgrammeConnector
-Updated the schedule fetch task to send notifs when changes are detected
-Added tests for schedule comparison and notification handling
Ran tests/program_notifications and all 41 passed