Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Feat/openssl update 2#14

Open
Aiiaiiio wants to merge 6 commits into
main from
feat/openssl-update-2
Open

Feat/openssl update 2 #14
Aiiaiiio wants to merge 6 commits into
main from
feat/openssl-update-2

Conversation

@Aiiaiiio

@Aiiaiiio Aiiaiiio commented Feb 25, 2026

Copy link
Copy Markdown
Member

Updated openssl to latest (3.6.1)

Copy link
Copy Markdown
Member

@chrip @DmySyz could you please review as well?

chrip commented Mar 3, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

I tried to build it, but it failed. Maybe a caching problem? Or path lib vs lib64? Pruning docker cache with docker builder prune -a helped in similar cases but not this time.

223.3 Fetch, patch Apple related 3rd-party repos
223.3 './fetch.sh' '/build-cache/third_party/install/apple'
223.3 Skipping Apple (done already).
223.3 Fetch and build icu (x2t_lib)
223.3 './nc-build.sh' '/build-cache/third_party/workdir/icu' '/build-cache/third_party/install/icu' '74' '2'
223.3 Skipping ICU (done already).
223.3 Fetch and build icu
223.3 './nc-build.sh' '/build-cache/third_party/workdir/icu' '/build-cache/third_party/install/icu' '74' '2'
223.3 Skipping ICU (done already).
223.3 Fetch and build icu (allthemesgen)
223.3 './nc-build.sh' '/build-cache/third_party/workdir/icu' '/build-cache/third_party/install/icu' '74' '2'
223.3 Skipping ICU (done already).
223.3 Fetch and build icu (pluginsmanager)
223.3 './nc-build.sh' '/build-cache/third_party/workdir/icu' '/build-cache/third_party/install/icu' '74' '2'
223.3 Skipping ICU (done already).
223.4 Fetch and build icu (app_builder)
223.4 './nc-build.sh' '/build-cache/third_party/workdir/icu' '/build-cache/third_party/install/icu' '74' '2'
223.4 Skipping ICU (done already).
223.4 Fetch and build OpenSSL
223.4 './nc-build.sh' '/build-cache/third_party/workdir/openssl' '/build-cache/third_party/install/openssl_build_linux_64'
223.4 Skipping OpenSSL (done already).
223.4 -- Configuring done (223.3s)
223.5 -- Generating done (0.1s)
223.6 -- Build files have been written to: /build-cache
223.6 ninja: error: 'third_party/install/openssl_build_linux_64/lib64/libssl.a', needed by 'x2t/library/kernel_network/libkernel_network.so', missing and no known rule to make it
------
Dockerfile:65
--------------------
 64 | 
 65 | >>> RUN --mount=type=cache,target=/build-cache \
 66 | >>> --mount=type=cache,target=/package/third_party/install \
 67 | >>> <<EOF
 68 | >>> set -e
 69 | >>> mkdir -p ${BUILD_ROOT}
 70 | >>> cd /build-cache
 71 | >>> 
 72 | >>> cmake -GNinja \
 73 | >>> -DCMAKE_BUILD_TYPE=Release \
 74 | >>> -DCMAKE_CXX_FLAGS_RELEASE="-O3" \
 75 | >>> -DCMAKE_C_FLAGS_RELEASE="-O3" \
 76 | >>> -DEO_CORE_OUTPUT_DIR=${BUILD_ROOT}/bin \
 77 | >>> -DEO_CORE_TOOLS_DIR=${BUILD_ROOT}/tools \
 78 | >>> /core
 79 | >>> 
 80 | >>> cmake --build .
 81 | >>> EOF
 82 | 
--------------------
ERROR: failed to build: failed to solve: process "/bin/sh -c set -e\nmkdir -p ${BUILD_ROOT}\ncd /build-cache\n\ncmake -GNinja \\\n -DCMAKE_BUILD_TYPE=Release \\\n -DCMAKE_CXX_FLAGS_RELEASE=\"-O3\" \\\n -DCMAKE_C_FLAGS_RELEASE=\"-O3\" \\\n -DEO_CORE_OUTPUT_DIR=${BUILD_ROOT}/bin \\\n -DEO_CORE_TOOLS_DIR=${BUILD_ROOT}/tools \\\n /core\n\ncmake --build .\n" did not complete successfully: exit code: 1
make: *** [Makefile:5: build-image] Error 1

Aiiaiiio commented Mar 4, 2026

Copy link
Copy Markdown
Member Author

I tried to build it, but it failed. Maybe a caching problem? Or path lib vs lib24? Pruning docker cache with docker builder prune -a helped in similar cases but not this time.

223.3 Fetch, patch Apple related 3rd-party repos
223.3 './fetch.sh' '/build-cache/third_party/install/apple'
223.3 Skipping Apple (done already).
223.3 Fetch and build icu (x2t_lib)
223.3 './nc-build.sh' '/build-cache/third_party/workdir/icu' '/build-cache/third_party/install/icu' '74' '2'
223.3 Skipping ICU (done already).
223.3 Fetch and build icu
223.3 './nc-build.sh' '/build-cache/third_party/workdir/icu' '/build-cache/third_party/install/icu' '74' '2'
223.3 Skipping ICU (done already).
223.3 Fetch and build icu (allthemesgen)
223.3 './nc-build.sh' '/build-cache/third_party/workdir/icu' '/build-cache/third_party/install/icu' '74' '2'
223.3 Skipping ICU (done already).
223.3 Fetch and build icu (pluginsmanager)
223.3 './nc-build.sh' '/build-cache/third_party/workdir/icu' '/build-cache/third_party/install/icu' '74' '2'
223.3 Skipping ICU (done already).
223.4 Fetch and build icu (app_builder)
223.4 './nc-build.sh' '/build-cache/third_party/workdir/icu' '/build-cache/third_party/install/icu' '74' '2'
223.4 Skipping ICU (done already).
223.4 Fetch and build OpenSSL
223.4 './nc-build.sh' '/build-cache/third_party/workdir/openssl' '/build-cache/third_party/install/openssl_build_linux_64'
223.4 Skipping OpenSSL (done already).
223.4 -- Configuring done (223.3s)
223.5 -- Generating done (0.1s)
223.6 -- Build files have been written to: /build-cache
223.6 ninja: error: 'third_party/install/openssl_build_linux_64/lib64/libssl.a', needed by 'x2t/library/kernel_network/libkernel_network.so', missing and no known rule to make it
------
Dockerfile:65
--------------------
 64 | 
 65 | >>> RUN --mount=type=cache,target=/build-cache \
 66 | >>> --mount=type=cache,target=/package/third_party/install \
 67 | >>> <<EOF
 68 | >>> set -e
 69 | >>> mkdir -p ${BUILD_ROOT}
 70 | >>> cd /build-cache
 71 | >>> 
 72 | >>> cmake -GNinja \
 73 | >>> -DCMAKE_BUILD_TYPE=Release \
 74 | >>> -DCMAKE_CXX_FLAGS_RELEASE="-O3" \
 75 | >>> -DCMAKE_C_FLAGS_RELEASE="-O3" \
 76 | >>> -DEO_CORE_OUTPUT_DIR=${BUILD_ROOT}/bin \
 77 | >>> -DEO_CORE_TOOLS_DIR=${BUILD_ROOT}/tools \
 78 | >>> /core
 79 | >>> 
 80 | >>> cmake --build .
 81 | >>> EOF
 82 | 
--------------------
ERROR: failed to build: failed to solve: process "/bin/sh -c set -e\nmkdir -p ${BUILD_ROOT}\ncd /build-cache\n\ncmake -GNinja \\\n -DCMAKE_BUILD_TYPE=Release \\\n -DCMAKE_CXX_FLAGS_RELEASE=\"-O3\" \\\n -DCMAKE_C_FLAGS_RELEASE=\"-O3\" \\\n -DEO_CORE_OUTPUT_DIR=${BUILD_ROOT}/bin \\\n -DEO_CORE_TOOLS_DIR=${BUILD_ROOT}/tools \\\n /core\n\ncmake --build .\n" did not complete successfully: exit code: 1
make: *** [Makefile:5: build-image] Error 1

If I understand correctly, "third_party/install/openssl_build_linux_64/lib64/libssl.a" is not found. The old openssl repo built it's libraries into lib, the new one builds into lib64. The fetch script will not do anything if the install directory already exists. So yeah, that directory has to be removed. Didn't think about this.
To be fair, I would not put much effort into fixing this imho, vcpkg is the real solution here.

rikled and others added 6 commits March 10, 2026 18:53
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Signed-off-by: Tamás Bari <adaorcpp@gmail.com>
Signed-off-by: Tamás Bari <adaorcpp@gmail.com>
Signed-off-by: Tamás Bari <adaorcpp@gmail.com>
Signed-off-by: Tamás Bari <adaorcpp@gmail.com>

toabctl commented Mar 28, 2026

Copy link
Copy Markdown

Have you seen ONLYOFFICE/core#1641 ?

chrip commented Mar 28, 2026

Copy link
Copy Markdown
Contributor

Have you seen ONLYOFFICE/core#1641 ?
Looks very promising! I'll take a closer look on Monday.

toabctl commented Mar 29, 2026
edited
Loading

Copy link
Copy Markdown

Have you seen ONLYOFFICE/core#1641 ?
Looks very promising! I'll take a closer look on Monday.

It would be nice if euro-office can be compiled against system libraries too. Not only against the bundled versions of the required libs.
Let me know if you have any questions or if there's anything I can help with.

toabctl commented Jun 9, 2026

Copy link
Copy Markdown

any updates on using system libs and current (CVE free) versions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rikled rikled Awaiting requested review from rikled

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /