-
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
Summary of ChangesHello @Jakubk15, I'm Gemini Code Assist1 ! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a robust and generic delay management system into the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a reusable Delay class. However, the Delay utility class, which uses the Caffeine caching library, has two medium-severity Denial of Service (DoS) vulnerabilities. These include an unbounded cache that could lead to memory exhaustion and an ArithmeticException in the expiration calculation logic due to unhandled overflow in Duration.toNanos() for durations exceeding 292 years. It is recommended to set a maximum cache size and add overflow protection for duration conversions. Furthermore, a critical issue in build.gradle.kts uses a non-existent dependency version, which will cause the build to fail. Lastly, improvements are needed in the Delay class for a logic issue in markDelay with non-positive durations, a performance opportunity in getExpireAt, and an API usability enhancement for getRemaining.
eternalcode-commons-shared/src/main/java/com/eternalcode/commons/delay/Delay.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Caffeine cache is initialized without a maximum size, which can lead to memory exhaustion if a large number of unique keys are added. This is especially risky if the keys are derived from untrusted user input (e.g., unique user IDs or IP addresses). Adding a limit prevents the cache from growing indefinitely.
this.cache = Caffeine.newBuilder() .expireAfter(new InstantExpiry<T>()) .maximumSize(1000) // TODO: Adjust this value based on expected usage .build();
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this will affect our use-cases
Delay classes are used commonly in our other projects, so now they will be in EternalCodeCommons.