-
-
Notifications
You must be signed in to change notification settings - Fork 150
Open
Conversation
Escartem
commented
Mar 13, 2026
Owner
Will test in the next days if this doesn't cause any unwanted side effects and then will merge
Owner
I have slightly modified the code again to keep the flag reading but without the issue you pinpointed, this should work now, feel free to comment again if you think it is still wrong, otherwise I'll commit within a few days
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the incorrect flag parsing logic in
Blb3File.ReadBlocksInfoAndDirectoryto fix #71:flagsfield is currently unused in the codebase, so this change doesn't affect existing functionalityThis is my first time writing a PR, so please forgive me if there are any inappropriate parts.