-
Notifications
You must be signed in to change notification settings - Fork 404
Comments
NOMERGE: [0.17] Signet implementation#433
Closed
jtimon wants to merge 4 commits intoElementsProject:elements-0.17 from
Closed
NOMERGE: [0.17] Signet implementation #433jtimon wants to merge 4 commits intoElementsProject:elements-0.17 from
jtimon wants to merge 4 commits intoElementsProject:elements-0.17 from
Conversation
@jtimon
jtimon
force-pushed
the
e17-signet
branch
4 times, most recently
from
October 14, 2018 22:36
7e93457 to
2b3b8c8
Compare
1 task
@jtimon
jtimon
force-pushed
the
e17-signet
branch
6 times, most recently
from
October 16, 2018 18:29
cc0f135 to
93d75f3
Compare
@jtimon
jtimon
force-pushed
the
e17-signet
branch
from
October 16, 2018 19:00
93d75f3 to
a300c95
Compare
This was referenced Oct 16, 2018
jtimon
added a commit
to jtimon/elements
that referenced
this pull request
Oct 16, 2018
jtimon
added a commit
to jtimon/elements
that referenced
this pull request
Oct 16, 2018
@jtimon
jtimon
force-pushed
the
e17-signet
branch
2 times, most recently
from
October 17, 2018 04:52
e55e65e to
5e9632a
Compare
@jtimon
jtimon
changed the title
(削除) [0.17] Signet implementation (削除ここまで)
(追記) NOMERGE: [0.17] Signet implementation (追記ここまで)
Oct 17, 2018
@jtimon
jtimon
force-pushed
the
e17-signet
branch
from
October 18, 2018 18:23
cec6830 to
554adf9
Compare
@jtimon
jtimon
force-pushed
the
e17-signet
branch
from
October 18, 2018 21:39
554adf9 to
9be2246
Compare
@jtimon
jtimon
force-pushed
the
e17-signet
branch
from
October 18, 2018 22:54
9be2246 to
c3f7bab
Compare
log "hit ^C to stop"
while true; do
let rv=$RANDOM%$randinterval
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs +$min_time
Contributor
instagibbs
commented
Oct 29, 2018
We're going to work directly on a branch, rather than a PR on top of elements-0.17.
Contributor
Author
jtimon
commented
Nov 22, 2018
You're going to need at least part of it here too, assuming #414 is merged and forward ported. putting it all facilitates testing since you wouldn't need a separated binary to test the fedpeg to a parent signet anymore.
But your call.
Contributor
instagibbs
commented
Nov 26, 2018
Not going to delete the branch to be clear. I made a copy to the repo: https://github.com/ElementsProject/elements/tree/e17-signet
IIRC I was getting conflicts as the base branch was moving along with features, and for now we just wanted a 0.17 Core branch to work on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
A rebase of kallewoof/bitcoin#5 on top of #432 taking the opportunity to simplify its changes around chainparams code and adding a test that also acts as a script to generate a private key in wallet importable format and its corresponding p2pk blockscript, which should be useful for people wanting to generate their own signets.
This represent a hardfork from that implementation because the genesis block now includes the name of the chain too, like all other custom chains, and the bits have to be low enough so that tests keep working with regtest-like pow.
Example to generate chain arguments:
That will generate:
Dependencies: