Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Comments

rpg::Actor Add unknown 3A and 40 chunks found in DynRPG#407

Open
mateofio wants to merge 1 commit intoEasyRPG:master from
mateofio:actorchunk
Open

rpg::Actor Add unknown 3A and 40 chunks found in DynRPG #407
mateofio wants to merge 1 commit intoEasyRPG:master from
mateofio:actorchunk

Conversation

@mateofio
Copy link
Contributor

@mateofio mateofio commented Oct 15, 2020

No description provided.

@ghost ghost added this to the 0.6.3 milestone Nov 9, 2020
@ghost ghost requested a review from Ghabry March 10, 2021 03:40
Copy link
Member

Ghabry commented Mar 16, 2021

btw while I was investigating the dungeon generator I'm pretty sure that I also found some unknown chunks in the code that reads the map properties:

In function 487A34 the values: 2B, 2C, 2D, 2E, 2F.

So I'm not really sure if we really want to document them all. There seem to be alot??

Copy link
Contributor Author

I'm on the fence about this one.

If they are truly not used at all by RPG_RT, then there isn't much value in adding memory for them to our structures. That includes the chunks in this PR.

That being said, we do want to be sure the chunk IDs don't get reused for some custom feature later.

Copy link
Member

Ghabry commented Mar 16, 2021

Not reusing the chunks is a valid concern. Lets keep this open longer, bet it is not hard to find even more...

fdela suggested they could be editor-only chunks (temporary data that is not saved).
But this investigating the editor which is some work...

@Ghabry Ghabry modified the milestones: 0.7.0, 0.7.1 Oct 21, 2021
@Ghabry Ghabry removed this from the 0.7.1 milestone Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ghabry Ghabry Awaiting requested review from Ghabry

1 more reviewer
Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /