-
Notifications
You must be signed in to change notification settings - Fork 429
Add retry mechanism with exponential backoff for Docker availability check #1910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add retry mechanism with exponential backoff for Docker availability check #1910
Conversation
Added to handle transient failures for when system is under load or docker has stalled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds resilience to the Docker availability check by implementing a retry mechanism with exponential backoff to handle transient Docker daemon failures under heavy system load. It also improves debugging by moving debug logging statements earlier in the execution flow.
Key changes:
- Implemented retry logic with exponential backoff for the
docker pscommand to handle transient Docker daemon unresponsiveness - Relocated debug logging statements to the beginning of
Runner::start()for better visibility when Docker checks fail
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
...gine into feat/docker-check-retry
Uh oh!
There was an error while loading. Please reload this page.
Problem
Under heavy system load,
docker pscan occasionally return exit code 1 due to transient Docker daemon/socket unresponsiveness, even when Docker is properly installed and running. This causes EasyEngine to fail with "Docker not installed or not running" error unnecessarily.Solution
argv, config paths) to the start ofRunner::start()for better debugging visibility when Docker checks fail