-
Notifications
You must be signed in to change notification settings - Fork 24
Comments
chore!: Bump node version requirement to v22.22; integrate react-compiler-tracker#994
Merged
frankieyan merged 6 commits intomain from Jan 21, 2026
Merged
chore!: Bump node version requirement to v22.22; integrate react-compiler-tracker #994frankieyan merged 6 commits intomain from
frankieyan merged 6 commits intomain from
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The integration of react-compiler-tracker logic into CI and pre-commit hooks looks logically sound. However, there is a critical configuration issue regarding the Node.js version: the PR specifies version 22.22, which does not exist (current LTS is v22.14.x), and the new dependency enforces this invalid version in its engine requirements. This will cause the CI pipeline and package installation to fail.
@frankieyan
frankieyan
changed the title
(削除) Integrate react-compiler-tracker into pre-commit and CI (削除ここまで)
(追記) chore: Integrate react-compiler-tracker into pre-commit and CI (追記ここまで)
Jan 19, 2026
@frankieyan
frankieyan
requested review from
a team and
gnapse
and removed request for
a team
January 20, 2026 03:11
@frankieyan
frankieyan
added
the
👀 Show PR
Used for PRs that need a review, but can be merged when CI is green.
label
Jan 20, 2026
gnapse
gnapse
approved these changes
Jan 20, 2026
Contributor
@gnapse
gnapse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
@frankieyan
frankieyan
changed the title
(削除) chore: Integrate react-compiler-tracker into pre-commit and CI (削除ここまで)
(追記) chore!: Integrate react-compiler-tracker into pre-commit and CI (追記ここまで)
Jan 20, 2026
@frankieyan
frankieyan
changed the title
(削除) chore!: Integrate react-compiler-tracker into pre-commit and CI (削除ここまで)
(追記) chore!: Bump node version requirement to v22.22; integrate react-compiler-tracker (追記ここまで)
Jan 21, 2026
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Bump minimum Node.js version from ^22.14.0 to ^22.22.0 to align with the @doist/react-compiler-tracker dependency requirement. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@frankieyan
frankieyan
force-pushed
the
frankieyan/react-compiler-tracker
branch
from
January 21, 2026 18:53
457a385 to
4650db7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Integrates react-compiler-tracker into our development workflow to catch React Compiler regressions early:
Note that this bumps the node version requirement to the most recent LTS under v22, hence the breaking change.
Test plan
Local (pre-commit):
- Temporarily comment out eslint from
- Add a rule violation to a component (e.g. reading
- Stage and commit — should fail with an error count increase
imagelint-staged.config.jsref.currentduring render)CI:
- Push a commit with
- Open a PR and verify the "Check React Compiler compatibility" step fails
image--no-verifythat introduces a new violationhttps://github.com/Doist/reactist/actions/runs/21158116009/job/60846968211?pr=996