-
Notifications
You must be signed in to change notification settings - Fork 49
Comments
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
PR: Implement Exchange Rates GraphQL Query & Frontend Display
Overview
This pull request implements the required functionality for fetching, caching, and displaying exchange rates, meeting the provided specifications for both backend and frontend. The changes include:
Backend Changes
GraphQL Query for Exchange Rates
A new GraphQL query has been added to return a list of exchange rates, integrating NestJS, TypeScript, and GraphQL.
Data Fetching from the Czech National Bank
The service located in
fullstack/task/packages/server/src/services/exchange-ratenow retrieves the latest rates from the Czech National Bank website.Caching with Postgres
Frontend Changes
Exchange Rates Table
A new React component (using TypeScript) has been added to display a table of exchange rates with the following details:
Cache Timestamp Display
A section has been added to show how long ago the exchange rates were fetched, based on the cache timestamp. This helps inform users about the data's freshness.
UI examples
Main
Screenshot 2025年01月20日 200558
Timestamp
Screenshot 2025年01月20日 200604
Small UI improvement: dark/light theme
Screenshot 2025年01月20日 201030
Notes
I have some issues with pnp on current machine so just used clasic approach.